[PATCH] D91092: [SVE][CodeGen] Lower scalable masked gathers

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-masked-gather-32b-unsigned-scaled.ll:11
+; CHECK:       // %bb.0:
+; CHECK-NEXT:    ld1h { z0.d }, p0/z, [x0, z0.d, sxtw #1]
+; CHECK-NEXT:    and z0.d, z0.d, #0xffff
----------------
sdesmalen wrote:
> Another thing I spotted, this should use `uxtw`, or use `sxtw` but then still keep the original zero-extend (`and`).
> So something in this patch is a bit too eager in removing the extend.
Good spot! I've removed the following lines from LowerMGATHER which was removing the extends:

```
if (getGatherScatterIndexIsExtended(Index))
    Index = Index.getOperand(0);
```
I will move this to D92319, where it should be safe to remove the extend after refineIndexType has already folded it into the index type


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91092/new/

https://reviews.llvm.org/D91092