[PATCH] D92059: [SLP] Control maximum vectorization factor from TTI

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 12:41:01 PST 2020


spatel added a comment.

In D92059#2421275 <https://reviews.llvm.org/D92059#2421275>, @jonpa wrote:

>> Not sure how appropriate is it to commit a target test using llc into the Transforms directory.
>
> You are probably right - perhaps it is enough to run opt and add a comment that explains that the CHECKed instructions would result in spilling

Yes, this is an SLP patch, so the regression test should only be `opt -slp-vectorizer` and auto-check all of the lines or minimally check just enough lines to determine that the IR instructions are or are not vectorized as expected. If we want an unoptimized IR -> asm test, that should go into the test-suite rather than the regression tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92059/new/

https://reviews.llvm.org/D92059



More information about the llvm-commits mailing list