[PATCH] D91576: [MemCpyOpt] Correctly merge alias scopes during call slot optimization

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

This looks good to me. I would improve the `alias-scope-merging.ll` test to explicitly check the merged scopes.



================
Comment at: llvm/test/Analysis/ScopedNoAliasAA/alias-scope-merging.ll:19
+; Merged scope contains "callee0: %a" and "callee0 : %b"
+; CHECK:   ![[SCOPE]] = !{!{{[0-9]+}}, !{{[0-9]+}}}
+
----------------
  -; CHECK:   ![[SCOPE]] = !{!{{[0-9]+}}, !{{[0-9]+}}}
  +; CHECK-DAG: ![[CALLEE0_A:[0-9]+]] = distinct !{!{{[0-9]+}}, !{{[0-9]+}}, !"callee0: %a"}
  +; CHECK-DAG: ![[CALLEE0_B:[0-9]+]] = distinct !{!{{[0-9]+}}, !{{[0-9]+}}, !"callee0: %b"}
  +; CHECK-DAG: ![[SCOPE]] = !{![[CALLEE0_A]], ![[CALLEE0_B]]}



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91576/new/

https://reviews.llvm.org/D91576