[PATCH] D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 02:46:33 PST 2020
foad added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:782
}
+ case GIM_CheckI64ImmArgPredicate: {
+ int64_t InsnID = MatchTable[CurrentIdx++];
----------------
gargaroff wrote:
> arsenm wrote:
> > Should probably group with case GIM_CheckI64ImmPredicate: {
> >
> > The name similarity is a bit confusing too
> Do you have a suggestion for a better name? I'm struggling to come up with a different one. The only other idea I have is `TImmPredicate`, which is just as similar.
"CheckI64ImmOperandPredicate"? Though there are plenty of other checks that check specific operands, that don't have "Operand" in their names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91703/new/
https://reviews.llvm.org/D91703
More information about the llvm-commits
mailing list