[PATCH] D92382: [llvm-readelf/obj] - Report unique warnings in `parseDynamicTable`.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 02:11:16 PST 2020


grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2092
     if (!MappedAddrOrError) {
-      Error Err =
-          createError("Unable to parse DT_" + Obj.getDynamicTagAsString(Tag) +
-                      ": " + llvm::toString(MappedAddrOrError.takeError()));
-
-      reportWarning(std::move(Err), ObjF.getFileName());
+      this->reportUniqueWarning("Unable to parse DT_" +
+                                Obj.getDynamicTagAsString(Tag) + ": " +
----------------
grimar wrote:
> jhenderson wrote:
> > Whilst you're changing this line, I recommend fixing the message case to match that from the coding standard.
> There are 4 test files with multiple places where this warning is reported. I'll fix this in a follow-up.
Fixed in rG1daace3fbb30


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92382/new/

https://reviews.llvm.org/D92382



More information about the llvm-commits mailing list