[PATCH] D92318: [llvm-readobj, libSupport] - Refine the implementation of the code that dumps build attributes.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 01:41:23 PST 2020
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2919
- // TODO: Delete the redundant FormatVersion check above.
- if (Machine == EM_ARM) {
- if (Error E = ARMAttributeParser(&W).parse(Contents, support::little))
- reportWarning(std::move(E), ObjF.getFileName());
- } else if (Machine == EM_RISCV) {
- if (Error E = RISCVAttributeParser(&W).parse(Contents, support::little))
- reportWarning(std::move(E), ObjF.getFileName());
- }
+ auto ParseAttrubutes = [&]() -> Error {
+ if (Machine == EM_ARM)
----------------
jhenderson wrote:
> Do you need the trailing return type? I don't think there's any conversion involved, so it should work without it?
I think so. I'll remove.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92318/new/
https://reviews.llvm.org/D92318
More information about the llvm-commits
mailing list