[PATCH] D92449: [X86] Sink x86_amx load in AMX type lowering.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 01:14:56 PST 2020


pengfei added a comment.

It's better to set parent since the patch is based on D91927 <https://reviews.llvm.org/D91927>.



================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:124
   std::tie(Row, Col) = getShape(II, OpNo);
-  IRBuilder<> Builder(LD);
+  auto *InsertPt = findSafePointToSink(*LD, *II, AA);
+  IRBuilder<> Builder(InsertPt);
----------------
Why don't pass the pointer directly for `LD` and `II`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92449/new/

https://reviews.llvm.org/D92449



More information about the llvm-commits mailing list