[PATCH] D92380: [llvm-readelf/obj] - Refine the error message about the broken string table.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 01:13:40 PST 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2047
           else
-            reportWarning(E.takeError(), ObjF.getFileName());
+            reportUniqueWarning("unable to get the string table for the " +
+                                describe(Sec) + ": " + toString(E.takeError()));
----------------
MaskRay wrote:
> Other messages don't prepend `the`
You mean before "decribe(Sec)"? In a few places we have it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92380/new/

https://reviews.llvm.org/D92380



More information about the llvm-commits mailing list