[PATCH] D92382: [llvm-readelf/obj] - Report unique warnings in `parseDynamicTable`.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM. The inline comment could be deferred if there are a number of places that would need updating.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2092
     if (!MappedAddrOrError) {
-      Error Err =
-          createError("Unable to parse DT_" + Obj.getDynamicTagAsString(Tag) +
-                      ": " + llvm::toString(MappedAddrOrError.takeError()));
-
-      reportWarning(std::move(Err), ObjF.getFileName());
+      this->reportUniqueWarning("Unable to parse DT_" +
+                                Obj.getDynamicTagAsString(Tag) + ": " +
----------------
Whilst you're changing this line, I recommend fixing the message case to match that from the coding standard.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92382/new/

https://reviews.llvm.org/D92382