[PATCH] D92456: [mac/lld] Make --reproduce work with thin archives

Tue Dec 1 20:42:40 PST 2020

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm

================
Comment at: lld/MachO/Driver.cpp:234
   Error err = Error::success();
+  bool addToTar = archive->isThin() && tar;
   for (const Archive::Child &c : archive->children(err)) {
----------------
would be nice to have a comment about why we need this only for thin archives

================
Comment at: lld/test/MachO/reproduce-thin-archives.s:18-19
+
+# CHECK2: [[PATH]]/foo.a
+# CHECK2: [[PATH]]/foo.o
+
----------------
the order of the files in the tar archive isn't actually important right? in that case we could just have two `CHECK-DAG` lines and do away with `CHECK2`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92456/new/

https://reviews.llvm.org/D92456