[PATCH] D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 19:32:35 PST 2020


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:403
+      std::move(dObj), "",
+      [&](Error err) { warn(getName() + ": " + toString(std::move(err))); },
+      [&](Error warning) {
----------------
thakis wrote:
> Since the arg here is called err, was this supposed to call error() instead of warn()? If not, this maybe deserves a comment.
This is copypasta from `*ObjFile<ELFT>::getDwarf()`. I'm not actually sure what kinds of malformed input triggers this...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89257/new/

https://reviews.llvm.org/D89257



More information about the llvm-commits mailing list