[PATCH] D92437: [mac/lld] Include archive name in diagnostics

Tue Dec 1 19:29:49 PST 2020

int3 added a comment.

Thanks! I was actually thinking about this missing feature while implementing D91318: [lld-macho] Add archive name and file modtime to STABS output <https://reviews.llvm.org/D91318>...

================
Comment at: lld/MachO/Driver.cpp:284
         for (const ArchiveMember &member : getArchiveMembers(*buffer))
-          if (hasObjCSection(member.mbref))
-            inputFiles.push_back(make<ObjFile>(member.mbref, member.modTime));
+          if (hasObjCSection(member.mbref)) {
+            inputFiles.push_back(
----------------
nit: If we're going to add braces, I'd prefer we add them around all 3 levels of nesting

================
Comment at: lld/MachO/InputFiles.h:74
+  // We use this string for creating error messages.
+  std::string archiveName;
+
----------------
why `std::string` over `StringRef`?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92437/new/

https://reviews.llvm.org/D92437