[PATCH] D92446: Avoid asserting when SizeOp0 isn't an exact multiple of NarrowSize.

Jake Goulding via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 18:48:15 PST 2020


shepmaster created this revision.
shepmaster added a reviewer: arsenm.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
shepmaster requested review of this revision.
Herald added a subscriber: wdng.

Addresses https://bugs.llvm.org/show_bug.cgi?id=48188


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92446

Files:
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp


Index: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -1024,6 +1024,11 @@
     Observer.changedInstr(MI);
     return Legalized;
   case TargetOpcode::G_PHI: {
+    // FIXME: add support for when SizeOp0 isn't an exact multiple of
+    // NarrowSize.
+    if (SizeOp0 % NarrowSize != 0)
+      return UnableToLegalize;
+
     unsigned NumParts = SizeOp0 / NarrowSize;
     SmallVector<Register, 2> DstRegs(NumParts);
     SmallVector<SmallVector<Register, 2>, 2> SrcRegs(MI.getNumOperands() / 2);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92446.308837.patch
Type: text/x-patch
Size: 673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201202/742cf796/attachment.bin>


More information about the llvm-commits mailing list