[PATCH] D92437: [mac/lld] Include archive name in diagnostics

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 17:35:01 PST 2020


thakis added a comment.

  Thanks!



================
Comment at: lld/MachO/InputFiles.cpp:419
+      [&](Error err) {
+        warn(toString(this) + ": " + toString(std::move(err)));
+      },
----------------
thakis wrote:
> Since the arg here is called `err`, was this supposed to call error() instead of warn()?
Asked this on D89257 like I should have in the first place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92437/new/

https://reviews.llvm.org/D92437



More information about the llvm-commits mailing list