[PATCH] D90059: [ms] [llvm-ml] Support command-line defines

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6920
+  }
+  Var.Redefinable = true;
+  Var.IsText = true;
----------------
epastor wrote:
> thakis wrote:
> > masm doesn't do it, but I think we should diag on redefinitions in -D flags, at least if the redefinition has a different value. that's likely always a bug in the  build system invoking us.
> I'm not sure there's a clean way to do this that isn't an error, and I'd like to maintain compatibility with ml64.exe on this. If you think it's worth special-casing this to plumb a warning through, we can do that... but I'm not convinced it's a good idea.
It'd match clang, which would be good, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90059/new/

https://reviews.llvm.org/D90059