[PATCH] D85264: Avoid redundant inline with LLVM_ATTRIBUTE_ALWAYS_INLINE

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 15:05:29 PST 2020


dblaikie added a comment.

In D85264#2420889 <https://reviews.llvm.org/D85264#2420889>, @jpark37 wrote:

> Is there something I need to do to land this? I'm new to LLVM.

Once a patch is approved, helps to ask to have it committed - otherwise folks tend to assume you have commit access and will commit it yourself. (I've gone ahead and committed this - it should automatically update the phab review and link the commit)

(details here: https://llvm.org/docs/Contributing.html#how-to-submit-a-patch "If you do not have commit access, please let people know during the review and someone should commit it on your behalf.")

Also, if you could upload future patches with full context that's handy (arc <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line> will do this for you, but if you are going to submit reviews via the web interface, this <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface> discusses how to include more context)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85264/new/

https://reviews.llvm.org/D85264



More information about the llvm-commits mailing list