[PATCH] D92429: [lld][WebAssembly] Feedback from D92038. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 1 14:54:21 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa38ed62ea803: [lld][WebAssembly] Feedback from D92038. NFC (authored by sbc100).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92429/new/
https://reviews.llvm.org/D92429
Files:
lld/test/wasm/weak-undefined-pic.s
lld/wasm/Symbols.h
Index: lld/wasm/Symbols.h
===================================================================
--- lld/wasm/Symbols.h
+++ lld/wasm/Symbols.h
@@ -160,6 +160,9 @@
// True if this symbol is a linker-synthesized stub function (traps when
// called) and should otherwise be treated as missing/undefined. See
// SymbolTable::replaceWithUndefined.
+ // These stubs never appear in the table and any table index relocations
+ // against them will produce address 0 (The table index representing
+ // the null function pointer).
bool isStub : 1;
uint32_t flags;
Index: lld/test/wasm/weak-undefined-pic.s
===================================================================
--- lld/test/wasm/weak-undefined-pic.s
+++ lld/test/wasm/weak-undefined-pic.s
@@ -27,7 +27,7 @@
.weak foo
.functype foo () -> (i32)
-# Verify that we do not generate dynamnic relocations for the GOT entry.
+# Verify that we do not generate dynamic relocations for the GOT entry.
# CHECK-NOT: __wasm_apply_relocs
@@ -68,7 +68,7 @@
# CHECK-NEXT: - Index: 1
# CHECK-NEXT: Name: 'undefined_weak:foo'
-# With `-pie` or `-shared` the resolution should is defered to the dynamic
+# With `-pie` or `-shared` the resolution should be deferred to the dynamic
# linker and the function address should be imported as GOT.func.foo.
#
# RUN: wasm-ld --experimental-pic -pie %t.o -o %t3.wasm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92429.308784.patch
Type: text/x-patch
Size: 1409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201201/4ba83341/attachment.bin>
More information about the llvm-commits
mailing list