[PATCH] D92430: [lld-macho] Add isCodeSection()

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 14:36:14 PST 2020


clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/InputSection.cpp:67
+  uint32_t attr = isec->flags & MachO::SECTION_ATTRIBUTES_USR;
+  if (attr == S_ATTR_PURE_INSTRUCTIONS)
+    return true;
----------------
BTW there is also a S_ATTR_SOME_INSTRUCTIONS attribute we might be able to use and improve.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92430/new/

https://reviews.llvm.org/D92430



More information about the llvm-commits mailing list