[PATCH] D92366: [lld-macho] Flesh out STABS implementation

[Jez Ng via Phabricator via llvm-commits]

int3 marked 2 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:654-655
+  for (Defined *defined : symbolsNeedingStabs) {
+    if (defined->isAbsolute())
+      continue;
+
----------------
clayborg wrote:
> You shouldn't need this because of lines 634 and 635 skips adding absolute symbols to symbolsNeedingStabs
ah yeah, copypasta mistake


================
Comment at: lld/MachO/SyntheticSections.cpp:677
+    // symbols?
+    if (isec->name == "__text") {
+      symStab.type = MachO::N_FUN;
----------------
clayborg wrote:
> Is this going to always work for all functions? This really needs to be bullet proof or dsymutil and lldb won't be able to find functions for this symbol.
Addressed here: D92430


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92366/new/

https://reviews.llvm.org/D92366