[PATCH] D89723: [CSSPGO][llvm-profgen]Context-sensitive profile data generation

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:155
+  }
+  ProfiledBinary *getBinary() { return Binary; }
+  bool hasNextLBR() { return LBRIndex < LBRStack.size(); }
----------------
hoy wrote:
> wlei wrote:
> > hoy wrote:
> > > Nit: `const` qualifier for these getters?
> > fixed, good suggestion, thanks!
> Actually I meant something like:
> 
> ```
> ProfiledBinary *getBinary() const { return Binary; }
> bool hasNextLBR() const { return LBRIndex < LBRStack.size(); }
> ...
> ```
> 
> Sorry for the confusion. 
fixed, thanks for clarification!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89723/new/

https://reviews.llvm.org/D89723