[PATCH] D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr

Tue Dec 1 12:55:54 PST 2020

stefanp added inline comments.

================
Comment at: lld/test/ELF/ppc64-call-tls-get-addr-missing.s:7
+## complain about the callee being missing.
+# CHECK: error: undefined symbol: __tls_get_addr
+CallOnly:
----------------
sfertile wrote:
> I'm trying to figure out the utility of this test. Referencing an undefined symbol should obviously be an error. Is the test meant to show we don't perform tls relaxations? If so I think the other tests cover that.
Yes this test was meant to show that the relaxations were not done. However, I agree with you this is probably already covered by the other tests. I'll remove this test.

================
Comment at: lld/test/ELF/ppc64-tls-add-missing-gdld.s:1
+# REQUIRES: ppc
+# RUN: split-file %s %t
----------------
sfertile wrote:
> The name of this file should be changed to match the direction change, or if it doesn't add anything that isn't already covered by `ppc64-tls-missing-gdld.s` it should be removed.
Yes, This test pretty much covers the same thing as `ppc64-tls-missing-gdld.s`.
I'm going to remove it as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91611/new/

https://reviews.llvm.org/D91611