[PATCH] D92415: [GWP-ASan] Fix flaky test on Fuchsia

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added a comment.

I'm troubled in two ways.

1. If this test is polluted by global (TLS) state from prior tests, that seems like a non-hermeticity problem for all these tests.  Should we maybe be using a test fixture with SetUp/TearDown to wipe the global state between tests?
2. It seems like the code under test actually has semantics that when uninitialized, it will sometimes sample (just rarely).  That seems like a problem to me.  If the initialized state as configured by the environment will be to never do a gwp allocation, then there should never be a window where one is randomly allowed to happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92415/new/

https://reviews.llvm.org/D92415