[PATCH] D92400: [AMDGPU] Stop adding an implicit def of vcc_hi for wave32

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:11567
       for (auto &MI : MBB) {
         TII->fixImplicitOperands(MI);
       }
----------------
foad wrote:
> arsenm wrote:
> > We should really fix the need for this loop too
> How? Would you need separate wave32/wave64 versions of every pseudo that has an implicit VCC operand? There are quite a few of those.
Yes, I think having to fixup every instruction is error prone and we have hit bugs from doing this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92400/new/

https://reviews.llvm.org/D92400