[PATCH] D92402: [InstSimplify] Allow isUndefValue(V) to return true if V is poison

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 11:24:04 PST 2020


nikic added a comment.

I don't think this change makes a lot of sense. I expect that in nearly all cases we'll be able to produce a better result by having a separate PoisonValue check beforehand (we'll want to return poison rather than undef or some other value). And if we do that, this change to the isUndefValue() API just makes things more confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92402/new/

https://reviews.llvm.org/D92402



More information about the llvm-commits mailing list