[PATCH] D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 11:12:42 PST 2020


I think Florian's diagnosis is worth looking into for sure - and probably
is the right solution. For the regressions I had they could largely be
explained by the branch predictor on a micro level, I didn't see some of
the large scale LTO level regressions in mine.

On Tue, Dec 1, 2020 at 5:10 AM Sanne Wouda via Phabricator <
reviews at reviews.llvm.org> wrote:

> sanwou01 added a comment.
>
> Just wanted to add to @fhahn that we're seeing this too, as an even more
> notable 8% regression (same benchmark, different hardware). Florian's
> explanation matches what I'm seeing, but I hadn't had a chance to confirm
> what was happening.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D84108/new/
>
> https://reviews.llvm.org/D84108
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201201/bfd734cd/attachment.html>


More information about the llvm-commits mailing list