[PATCH] D92261: [dfsan] Track field/index-level shadow values in variables

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao added a comment.

> This is a fairly large patch; would it be possible to split it into a series of dependent patches?  For example, the renaming/refactoring stuff could go in its own patch and probably the changes to select.ll could as well.  If there's a way to also split the functional changes, that would be even better.  This would make it easier for me to review and give better feedback.

Is the following split bette?

1. the extension of __dfsan_arg_tls and __dfsan_ret_tls. This also updates test cases that check them. For example, select.ll
2. rename ShadowTy/ZeroShadow to PrimaryShadowTy/ZeroShadowTy
3. modification of test cases phi.ll and load.ll since they can test the existing work too.
4. the rest functional change that supports field-level accuracy. This part is hard to split because we may have to make all instruction propagation use the same shadow value to make it work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92261/new/

https://reviews.llvm.org/D92261