[PATCH] D70655: [AutoFDO] Top-down Inlining for specialization with context-sensitive profile

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1826
       &getAnalysis<ProfileSummaryInfoWrapperPass>().getPSI();
-  return SampleLoader.runOnModule(M, nullptr, PSI);
+  return SampleLoader.runOnModule(M, nullptr, PSI, nullptr);
 }
----------------
ychen wrote:
> The new pass manager computes the call graph but here it is skipped. Should we also compute the call graph here?
Passing a call graph into the sample loader sounds helpful to me. I'm not sure if there is an available `FunctionAnalysisManager` object so that the call graph can be reused. Computing a call graph on the spot might hurt the compiler throughput. @wenlei can you shed light on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70655/new/

https://reviews.llvm.org/D70655