[PATCH] D91968: llvm/ADT/StringExtras.h hexDigitValue - Init of integer buffer

Tue Dec 1 08:32:52 PST 2020

jerker.back added a comment.

In D91968#2424469 <https://reviews.llvm.org/D91968#2424469>, @dexonsmith wrote:

> In D91968#2412092 <https://reviews.llvm.org/D91968#2412092>, @joerg wrote:
>
>> Do we really want to change the code here? It is perfectly well defined behavior.
>
> I weakly agree with @joerg, I would have thought we have lots of cases of `-1U` since it's a common / well-understood way to get this value. Is the warning possible to turn off? Have you reported a compiler bug?

As I said in the beginning, this is a compiler warning turned into an error by a default compiler option (-sdl, Security Development Lifecycle (SDL) checks). The option can be turned off. It's a bit unclear under what conditions exactly the option is default, off or disabled. The issue is well known and not a bug.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91968/new/

https://reviews.llvm.org/D91968