[PATCH] D92360: [lld/mac] Fix issues around thin archives

Tue Dec 1 06:48:51 PST 2020

thakis added inline comments.

================
Comment at: lld/test/MachO/thin-archive.s:13
+# RUN: %lld %t/main.o %t/lib.a -o %t/out 2>&1 | \
+# RUN:     FileCheck --allow-empty %s
+# RUN: %lld %t/main.o %t/lib_thin.a -o %t/out 2>&1 | \
----------------
int3 wrote:
> is running FileCheck really necessary here if the input is going to be empty? I guess the intent is to verify that the `CHECK-NOT` line doesn't match, but if lld were emitting an error, this line would fail anyway...
> 
> might be clearer to just run the commands and check that `out` contains the symbol definition, similar to what `archive.s` is doing
Whoops, missed this. Sure, done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92360/new/

https://reviews.llvm.org/D92360