[PATCH] D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture
Lucas Prates via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 1 06:27:13 PST 2020
pratlucas marked 4 inline comments as done.
pratlucas added a comment.
As suggested in D91773 <https://reviews.llvm.org/D91773>, I've squashed the two patches together in this single review.
The comments from D91773 <https://reviews.llvm.org/D91773> were addressed in this latest version.
================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3149
+ assert(Mnemonic == "dsb" && "Instruction does not accept nXS operands");
+ if (Mnemonic != "dsb")
+ return MatchOperand_ParseFail;
----------------
ostannard wrote:
> This isn't needed with the assertion above.
I'd rather keep this if to make sure we properly get a ParseFail result if assertions are disabled.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91772/new/
https://reviews.llvm.org/D91772
More information about the llvm-commits
mailing list