[lld] 4431c21 - lld/ELF: Make three rarely-used flags work with --reproduce

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 06:20:53 PST 2020


Author: Nico Weber
Date: 2020-12-01T09:20:29-05:00
New Revision: 4431c212a0a08c2b6552e6a476a15b142d7c6bb9

URL: https://github.com/llvm/llvm-project/commit/4431c212a0a08c2b6552e6a476a15b142d7c6bb9
DIFF: https://github.com/llvm/llvm-project/commit/4431c212a0a08c2b6552e6a476a15b142d7c6bb9.diff

LOG: lld/ELF: Make three rarely-used flags work with --reproduce

All three use readFile() for their argument so their argument file is
already copied to the tar, but we weren't rewriting the argument to
point to the path used in the tar file.

No test because the change is trivial (several other flags in
createResponseFile() also aren't tested, likely for the same reason.)

Differential Revision: https://reviews.llvm.org/D92356

Added: 
    

Modified: 
    lld/ELF/DriverUtils.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/DriverUtils.cpp b/lld/ELF/DriverUtils.cpp
index 2efd92a3df764..fd649808c0607 100644
--- a/lld/ELF/DriverUtils.cpp
+++ b/lld/ELF/DriverUtils.cpp
@@ -186,8 +186,11 @@ std::string elf::createResponseFile(const opt::InputArgList &args) {
       // Strip directories to prevent the issue.
       os << "-o " << quote(path::filename(arg->getValue())) << "\n";
       break;
+    case OPT_call_graph_ordering_file:
     case OPT_dynamic_list:
+    case OPT_just_symbols:
     case OPT_library_path:
+    case OPT_retain_symbols_file:
     case OPT_rpath:
     case OPT_script:
     case OPT_symbol_ordering_file:


        


More information about the llvm-commits mailing list