[PATCH] D91441: [VP] Build VP SDNodes

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 05:55:44 PST 2020


simoll updated this revision to Diff 308624.
simoll marked 6 inline comments as done.
simoll added a comment.

Thanks for your feedback so far!

- Tests: use `not --crash` instead of piping to `true`. (Hexagon tests do the same thing).
- Say `VPIntrin` instead of `VPI`.
- Say `SDOPC` instead of `SDID`.
- Added `llvm_unreachable()` if no SDNode opcode is available for a given vp intrinsic.
- Fixed various cases of `can(n)onical` i missed in the last update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91441/new/

https://reviews.llvm.org/D91441

Files:
  llvm/include/llvm/CodeGen/ISDOpcodes.h
  llvm/include/llvm/IR/VPIntrinsics.def
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/test/CodeGen/VE/Vector/vp_add.ll
  llvm/test/CodeGen/VE/Vector/vp_and.ll
  llvm/test/CodeGen/VE/Vector/vp_ashr.ll
  llvm/test/CodeGen/VE/Vector/vp_lshr.ll
  llvm/test/CodeGen/VE/Vector/vp_mul.ll
  llvm/test/CodeGen/VE/Vector/vp_or.ll
  llvm/test/CodeGen/VE/Vector/vp_sdiv.ll
  llvm/test/CodeGen/VE/Vector/vp_shl.ll
  llvm/test/CodeGen/VE/Vector/vp_srem.ll
  llvm/test/CodeGen/VE/Vector/vp_sub.ll
  llvm/test/CodeGen/VE/Vector/vp_udiv.ll
  llvm/test/CodeGen/VE/Vector/vp_urem.ll
  llvm/test/CodeGen/VE/Vector/vp_xor.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91441.308624.patch
Type: text/x-patch
Size: 23379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201201/3a6500a3/attachment.bin>


More information about the llvm-commits mailing list