[PATCH] D91876: [DAG] Move vselect(icmp_ult, -1, add(x,y)) -> uaddsat(x,y) to DAGCombine (PR40111)
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 1 03:35:00 PST 2020
RKSimon added inline comments.
================
Comment at: llvm/test/CodeGen/X86/sat-add.ll:726-727
+; SSE42-NEXT: pcmpgtq %xmm2, %xmm1
+; SSE42-NEXT: por %xmm0, %xmm1
+; SSE42-NEXT: movdqa %xmm1, %xmm0
; SSE42-NEXT: retq
----------------
pengfei wrote:
> Nit: There seems an extra mov.
Yeah - its particularly annoying as POR is commutable!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91876/new/
https://reviews.llvm.org/D91876
More information about the llvm-commits
mailing list