[PATCH] D92369: [ARM] Improve handling of empty VPT blocks in tail predicated loops

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 02:53:29 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:316
+        // anything valid once we remove the VCTP. For now just bail out.
+        if (Insts.size() == 2 && Insts.front()->getOpcode() != ARM::MVE_VPST &&
+            isVCTP(Insts.back()))
----------------
Perhaps I am confused, but should this:

  Insts.front()->getOpcode() != ARM::MVE_VPST

not be be `==`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92369/new/

https://reviews.llvm.org/D92369



More information about the llvm-commits mailing list