[PATCH] D92083: Legalize the SETCC/STRICT_FSETCCS as libcall

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4475
+    if (RHS.getNode())
+      LHS = DAG.getNode(ISD::SETCC, dl, Node->getValueType(0), LHS, RHS,
+                        DAG.getCondCode(CCCode));
----------------
qiucf wrote:
> Will this okay if `IsStrict == true`?
It is the compare of integer type not floating type.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8176
+  // Not FP, or using SPE? Not a fsel.
+  if (!CmpVT.isFloatingPoint() || !TV.getValueType().isFloatingPoint() ||
+      Subtarget.hasSPE())
----------------
qiucf wrote:
> This early return isn't about `P8` or `P9`?
It is old logic. What I did is just replacing the Op.getOperand(0).getValueType() with CmpVT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92083/new/

https://reviews.llvm.org/D92083