[PATCH] D90349: [DAGCombiner] Improve shift by select of constant

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/select_const.ll:632
+; NO_ISEL-NEXT:    addi 3, 4, 0
+; NO_ISEL-NEXT:    blr
   %sel = select i1 %cond, i8 2, i8 3
----------------
RKSimon wrote:
> laytonio wrote:
> > RKSimon wrote:
> > > any ideas on these regressions?
> > > any ideas on these regressions?
> > 
> > Forgive me, I'm not very familiar with PowerPC, but is this actually worse? It now looks just like the above unaltered test for select of constants shifted by constant. If it is worse, should we change that as well?
> @nemanjai how much of an issue is this?
@nemanjai ping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90349/new/

https://reviews.llvm.org/D90349