[PATCH] D92316: [llvm-readobj][test] - Merge 2 test cases together.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 00:27:46 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/invalid-attributes-sec.test:25-26
+
+## Check we report a warning when the length of the attributes data
+## of the SHT_RISCV_ATTRIBUTES section is zero.
+
----------------
The intent of the `invalid-attr-section-size.test` was simply to show that llvm-readobj usefully reports the errors reported by the attribute parser, hence why the comment didn't mention the specific details. See https://reviews.llvm.org/D75833#1948304 and other comments in that review for context. Perhaps it is worth keeping the comment for that case generic like in the original, so that the intent isn't lost (the attribute parser unit tests are for testing the details of the parser).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92316/new/

https://reviews.llvm.org/D92316



More information about the llvm-commits mailing list