[PATCH] D91249: [obj2yaml] - Teach tool to emit the "SectionHeaderTable" key and sort sections by file offset.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I think you might need some test coverage for fills too? At least the code you're working on works with `Chunk` instances, so it implies that both Sections and Fills can reach this bit.



================
Comment at: llvm/test/tools/obj2yaml/ELF/section-headers.yaml:1
+## Test how we dump objects where the order of sections in the
+## section header table does not match their actual order.
----------------
I'm not sure you really need this test. `offset.yaml` provides the same level of coverage and actually provides better coverage (it also shows that the section header table isn't printed when the sections are already in order).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91249/new/

https://reviews.llvm.org/D91249