[PATCH] D92218: [llvm-readelf/obj] - Move unique warning handling logic to the `ObjDumper`.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 23:57:16 PST 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ObjDumper.cpp:43-44
+  handleAllErrors(std::move(Err), [&](const ErrorInfoBase &EI) {
+    cantFail(WarningHandler(EI.message()),
+             "WarningHandler should always return ErrorSuccess");
+  });
----------------
jhenderson wrote:
> Maybe we could simplify this by having `WarningHandler` not return an Error at all? What do you think?
I'll take a look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92218/new/

https://reviews.llvm.org/D92218



More information about the llvm-commits mailing list