[PATCH] D92359: [WebAssembly] Support select and block for reference types

[Heejin Ahn via Phabricator via llvm-commits]

aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/reference-types.s:8
+ref_null_test:
+  .functype ref_null_test() -> ()
+  ref.null func
----------------
sbc100 wrote:
> aheejin wrote:
> > sbc100 wrote:
> > > Isn't it useful to continue to test `externref` and `funcref` as function return types?  Or is that tested elsewhere?
> > `llvm-mc` cannot check the correctness of that. We can put any signature here and the test will pass anyway.
> But it must be at least checked for valid type?
> 
> You can write `(foo) -> (bar)` can you?    It might be good to check that these types are accepted in this position?
I added two more tests to test reference type signatures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92359/new/

https://reviews.llvm.org/D92359