[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D92189#2420932 <https://reviews.llvm.org/D92189#2420932>, @Meinersbur wrote:

> Looking at `CodeGenFunction::GenerateOpenMPCapturedVars`, the condition `if (!CurField->getType()->isAnyPointerType())` seems to match what is done here, but I wonder whether it is always necessary. Is the additional indirection necessary for pointer-sized data types (e.g. `intptr_t`, or smaller)?
>
> Aside this optimization, the change looks like something has to be done. Can you update the naming conventions pointed-out by clang-tidy?

Let's keep it simple. TBH, I am not convinced Clang's "optimization" is not hurting us in the long run. I mean, we'd need to understand this: `bitcast float to i32 -> zext ---fork_call---> trunc -> bitcast i32 to float` while the pointer indirection is common also for shared values so we will be (actually are downstream) able to handle those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92189/new/

https://reviews.llvm.org/D92189