[PATCH] D82919: [SampleFDO] Enable sample-profile-top-down-load by default.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1791
   if (!ProfileTopDownLoad || CG == nullptr) {
+    if (ProfileMergeInlinee) {
+      // Disable ProfileMergeInlinee if profile is not loaded in top down order,
----------------
hoy wrote:
> ychen wrote:
> > I don't fully understand the patch TBH. `ProfileMergeInlinee` is also set to false when `CG == nullptr` which holds true when the legacy pass manager is used. Is this intended?
> `ProfileMergeInlinee` is set to false when a top-down inlining is not available.  This happens when the top-down inlining is explicitly disabled, or when a call graph is not available which means a top-down order cannot be computed.
@hoy, thank you. I just realized that I should've asked this in D70655 where the call graph is not computed hence not available for the legacy pass manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82919/new/

https://reviews.llvm.org/D82919