[PATCH] D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:538-541
+      for (SmallVectorImpl<ActionEntry>::const_iterator I = Actions.begin(),
+                                                        E = Actions.end();
+           I != E; ++I) {
+        const ActionEntry &Action = *I;
----------------
Range-based `for` should work here.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:542
+        const ActionEntry &Action = *I;
+        // Each action entry is consist of two sleb128 fields.
+        ActionTableSize += getSLEB128Size(Action.ValueForTypeID) +
----------------
Minor nit: grammar, style.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:552
+          1                          // Call site encoding byte.
+          + ByteSizeOfCallSiteOffset // uleb128 encoding of CallSiteTableSize.
+          + CallSiteTableSize        // Call site Table content.
----------------
Minor nit: style.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92058/new/

https://reviews.llvm.org/D92058