[PATCH] D92356: lld/ELF: Make three rarely-used flags work with --reproduce

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 16:56:50 PST 2020


thakis created this revision.
thakis added a reviewer: MaskRay.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
thakis requested review of this revision.

All three use readFile() for their argument so their argument file is
already copied to the tar, but we weren't rewriting the argument to
point to the path used in the tar file.

No test because the change is trivial (several other flags in
createResponseFile() also aren't tested, likely for the same reason.)


https://reviews.llvm.org/D92356

Files:
  lld/ELF/DriverUtils.cpp


Index: lld/ELF/DriverUtils.cpp
===================================================================
--- lld/ELF/DriverUtils.cpp
+++ lld/ELF/DriverUtils.cpp
@@ -186,8 +186,11 @@
       // Strip directories to prevent the issue.
       os << "-o " << quote(path::filename(arg->getValue())) << "\n";
       break;
+    case OPT_call_graph_ordering_file:
     case OPT_dynamic_list:
+    case OPT_just_symbols:
     case OPT_library_path:
+    case OPT_retain_symbols_file:
     case OPT_rpath:
     case OPT_script:
     case OPT_symbol_ordering_file:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92356.308503.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201201/9d2f4a7b/attachment.bin>


More information about the llvm-commits mailing list