[PATCH] D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 16:41:49 PST 2020


amccarth accepted this revision.
amccarth added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/interception/interception_win.cpp:139
 static const int kShortJumpInstructionLength = 2;
-static const int kIndirectJumpInstructionLength = 6;
+UNUSED static const int kIndirectJumpInstructionLength = 6;
 static const int kBranchLength =
----------------
I suppose this is fine, but it seems most of these could be `constexpr`, which would obviate the need for the preprocessor macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91852/new/

https://reviews.llvm.org/D91852



More information about the llvm-commits mailing list