[PATCH] D82919: [SampleFDO] Enable sample-profile-top-down-load by default.
Yuanfang Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 15:35:35 PST 2020
ychen added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1791
if (!ProfileTopDownLoad || CG == nullptr) {
+ if (ProfileMergeInlinee) {
+ // Disable ProfileMergeInlinee if profile is not loaded in top down order,
----------------
I don't fully understand the patch TBH. `ProfileMergeInlinee` is also set to false when `CG == nullptr` which holds true when the legacy pass manager is used. Is this intended?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82919/new/
https://reviews.llvm.org/D82919
More information about the llvm-commits
mailing list