[PATCH] D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

> Thanks for thinking it through! I also appreciate hearing about the the pre-3.0 days; I wasn't aware of that history (and how we're revisiting similar solutions).

Yeah, appreciate the thoughts/context. (I came in /just/ after the 3.0 days - some of my first patches were cleaning up/removing "const" on "const Type" because Type was now immutable)

> Note that if you want more discussion of the opaque pointers, David gave an LLVM talk a while ago (https://www.youtube.com/watch?v=OWgWDx_gB1I). He left a few exercises for the viewer/listener which I think are slowly being worked through (I've been following it mostly from a distance, but it appears to be getting close).

Yep, that's about the size of it. Few folks have chipped in here and there - glad to help/might be able to pick up some of it myself here and there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78793/new/

https://reviews.llvm.org/D78793