[PATCH] D91460: [AsmParser] make .ascii support spaces as separators
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 30 14:58:14 PST 2020
nickdesaulniers added inline comments.
================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3034-3035
+ // https://reviews.llvm.org/D91460 for more details
+ if ((!ZeroTerminated && parseManyWithOptionalComma()) ||
+ (ZeroTerminated && parseMany(parseOp)))
return addErrorSuffix(" in '" + Twine(IDVal) + "' directive");
----------------
Would a ternary expression make sense here?
```
if (ZeroTerminated ? parseMany(parseOp) : parseManyWithOptionalComma())
return ...;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91460/new/
https://reviews.llvm.org/D91460
More information about the llvm-commits
mailing list