[PATCH] D91816: [Inline] prevent inlining on stack protector mismatch

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.

Cool, that should be all of the feedback addressed. How does it look?



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2431
   bool ReturnsTwice = F.hasFnAttribute(Attribute::ReturnsTwice);
-  for (Function::iterator BI = F.begin(), BE = F.end(); BI != BE; ++BI) {
+  for (BasicBlock &BB : F) {
     // Disallow inlining of functions which contain indirect branches.
----------------
MaskRay wrote:
> Is the block unrelated changes?
https://reviews.llvm.org/D92350


================
Comment at: llvm/test/CodeGen/X86/stack-protector-2.ll:165
 
+; Test that the same function body does not get a canary if no ssp fn attrs are
+; set.
----------------
MaskRay wrote:
> Does the comment apply to bar_sspstrong? I don't get the meaning...
reworded, WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91816/new/

https://reviews.llvm.org/D91816