[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 14:27:16 PST 2020


zequanwu added a comment.

In D91673#2401578 <https://reviews.llvm.org/D91673#2401578>, @xur wrote:

> This is probably OK for -Os (SizeLevel == 1), but we need to be careful with Oz (SizeLevel == 2).
> We already know that enabling preinliner in general will reduce size -- as the preinliner is pretty conservative. But there will be cases size will be increased.
>
> I would like more test results (like bootstrap clang) before committing.

I don't see binary size difference (<1%), when bootstrap clang with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91673/new/

https://reviews.llvm.org/D91673



More information about the llvm-commits mailing list